Open
Conversation
Flickering Issue when moving up and down a scrollable document while the sidebar is open See: SidebarJS/angular-sidebarjs#7 This is generated when updating the sidebarjs.scss file and compile the CSS. Added the following in the --is-moving class: [sidebarjs-container] { transform: none!important; } in the following. [sidebarjs] { @extend %component--full-screen; position: fixed; z-index: 9999; transition: transform 0s $timing $duration; &.sidebarjs--is-visible { @include component--is-visible; } &.sidebarjs--is-moving { transition: none; transform: translate(0, 0); **[sidebarjs-container] { transform: none!important; }** [sidebarjs-container], [sidebarjs-backdrop] { transition: none; } } } The issue is that every time the user moves up and down the transform property always gets updated. That's the reason for the flickering issue. To fix that, I added an override to force the transform to none.
|
Hi,I have tryied your css fix, it did fixed the moving sidebar but it looses the transition if you are done scrolling and tryied to open or close the sidebar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flickering Issue when moving up and down a scrollable document while the sidebar is open
See: SidebarJS/angular-sidebarjs#7
This is generated when updating the sidebarjs.scss file and compile the CSS.
Added the following in the --is-moving class:
[sidebarjs-container] {
transform: none!important;
}
in the following.
[sidebarjs] {
@extend %component--full-screen;
position: fixed;
z-index: 9999;
transition: transform 0s $timing $duration;
&.sidebarjs--is-visible {
@include component--is-visible;
}
&.sidebarjs--is-moving {
transition: none;
transform: translate(0, 0);
[sidebarjs-container] {
transform: none!important;
}
[sidebarjs-container],
[sidebarjs-backdrop] {
transition: none;
}
}
}
The issue is that every time the user moves up and down the transform property always gets updated. That's the reason for the flickering issue. To fix that, I added an override to force the transform to none.